Fix terminal suggest relative path normalization for ls ../
#287178
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Terminal suggestions for
ls ../incorrectly showed files from two levels up instead of one. ThegetCWDForFilesAndFoldersfunction concatenated paths without normalizing, producing/home/user/project/../instead of/home/user/.Changes
Path normalization: Added
path.normalize()togetCWDForFilesAndFoldersinextensions/terminal-suggest/src/fig/shared/utils.tsto resolve.and..components before returning the directory pathTest coverage: Added test suite for
getCWDForFilesAndFolderscovering:../,./)Example fix:
Existing test expectations in
ls.test.tsandcd.test.tsalready validate this behavior.Original prompt
ls ../brings up wrong file suggestions #287161💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.